New sparse caught that typo which could have caused erratic hardware behaviour on some machines if the platform functions are used by the firmware to change bits in some FCR registers. Signed-off-by: Benjamin Herrenschmidt Index: linux-2.6.16.13-4/arch/powerpc/platforms/powermac/pfunc_base.c =================================================================== --- linux-2.6.16.13-4.orig/arch/powerpc/platforms/powermac/pfunc_base.c +++ linux-2.6.16.13-4/arch/powerpc/platforms/powermac/pfunc_base.c @@ -258,7 +258,7 @@ static struct pmf_handlers macio_mmio_ha .write_reg32 = macio_do_write_reg32, .read_reg32 = macio_do_read_reg32, .write_reg8 = macio_do_write_reg8, - .read_reg32 = macio_do_read_reg8, + .read_reg8 = macio_do_read_reg8, .read_reg32_msrx = macio_do_read_reg32_msrx, .read_reg8_msrx = macio_do_read_reg8_msrx, .write_reg32_slm = macio_do_write_reg32_slm,